Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: token network selector (WIP) #12224

Closed
wants to merge 144 commits into from
Closed

feat: token network selector (WIP) #12224

wants to merge 144 commits into from

Conversation

vinnyhoward
Copy link
Contributor

Description

This is a rough WIP. Please be kind 🥲

This is a work in progress to mirror the extension counterpart

Related issues

Fixes:

Manual testing steps

  1. WIP

Screenshots/Recordings

WIP

Before

WIP

After

WIP

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

gambinish and others added 30 commits September 26, 2024 17:09
@gambinish
feat: Add sortAssets utility function
0248c74
@gambinish
chore: Breakup monolithic Tokens/index.tsx into smaller components
6a2e8c7
@gambinish
fix: Correctly handle null check for buyable footer button
7a78717
@gambinish
fix: Tweak boolean logic for rendering footer components
57295ee
@gambinish
chore: Update snapshot
d00354f
@gambinish
chore: Type out tokens as TokenI[]
be87f81
@gambinish
chore: Remove unecessary comments around import statements in Networt…
68c7b2e 
…h component
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
a02e139
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
de5bbed
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
0fd9ad5
@gambinish
chore: Add unit tests to utility file, provide exports from index file
032618c
@gambinish
chore: Rename handleBalance to me more descriptive of what its logic …
a58f1ba 
…is handling
@gambinish
chore: rename Networth to PortfolioBalance for clarity
1dd31e3
@gambinish
chore: Cleanup styles extra whitespace
16ded6a
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
52d3d85
@gambinish
fix: Update snapshot tests
dd3ffdf
@gambinish
Merge branch 'chore/componetize-tokens-screen' of github.com:MetaMask…
da640bc 
…/metamask-mobile into chore/componetize-tokens-screen
@gambinish
fix: Remove unused component
ebcbcf6
@gambinish
Merge branch 'main' into chore/componetize-tokens-screen
31fad19
@gambinish
chore: Move PotfolioBalance above TabView
4a8d927
@gambinish
fix: Wrap PortfolioBalance and ScrollableView in fragment for token r…
a7b4c17 
…endering
@gambinish
fix: Padding tweak below tab bar for consistency of token list
658fcf6
@gambinish
fix: Reorganize test suite for PortfolioBalance
18035d4
@gambinish
fix: Revert changes to wallet test
c570c2c
@gambinish
fix: Update fiatBalance text style to DisplayMD
a97128b
@gambinish
chore: Patch PreferencesController with tokenSortConfig
8036a0a
@gambinish
chore: Patch preferences controller with type
1f0ac51
@gambinish
feat: Build token sorting UI, patch PreferencesController
34d987c
@gambinish
chore: Merge main, address merge conflicts
d57558b
@gambinish
fix: ListHeaderComponent not needed in FlatList anymore
c5c954c
gambinish and others added 11 commits November 5, 2024 08:04
@gambinish
Merge branch 'main' into feat/mmassets-431_network-filter-ui
9d3260e
@gambinish
refactor: Update AssetListControls buttons to icons per design revisions
b2781a5
@gambinish
fix: Update button text wrapping with snapshots
f3b9a14
@gambinish
Merge branch 'feat/mmassets-431_network-filter-ui' of github.com:Meta…
4a52719 
…Mask/metamask-mobile into feat/mmassets-431_network-filter-ui
@gambinish
Merge branch 'main' into feat/mmassets-431_network-filter-ui
e392f21
@gambinish
fix: Lint
68a76d6
@gambinish
Merge branch 'feat/mmassets-431_network-filter-ui' of github.com:Meta…
166ac02 
…Mask/metamask-mobile into feat/mmassets-431_network-filter-ui
@gambinish
Merge branch 'main' into feat/mmassets-431_network-filter-ui
fcafb86
@gambinish
Merge branch 'main' into feat/mmassets-431_network-filter-ui
de35586
@gambinish
chore: Replace unrelated build flag
edc8c5c
@vinnyhoward
feat: filtering tokens by all networks or one network
5aef7ba
@vinnyhoward vinnyhoward added DO-NOT-MERGE Pull requests that should not be merged No E2E Smoke Needed If the PR does not need E2E smoke test run team-wallet-ux labels Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

gambinish and others added 12 commits November 7, 2024 08:08
@gambinish
Merge branch 'main' into feat/mmassets-431_network-filter-ui
915549e
@vinnyhoward
Merge branch 'feat/mmassets-431_network-filter-ui' of github.com:Meta…
f83b81a 
…Mask/metamask-mobile into feat-431-network-filter-selector
@vinnyhoward
fix: renaming test file to match component file
a06c896
@vinnyhoward
fix: revert change - wrong branch
82f69bd
@gambinish
fix: Remove unused font style
ab20b3e
@gambinish
fix: Use true for feature flag
fd28086
@vinnyhoward
Merge branch 'feat/mmassets-431_network-filter-ui' of github.com:Meta…
94e9bfe 
…Mask/metamask-mobile into feat-431-network-filter-selector
@gambinish
fix: Unblock podfile during CI
db79b71
@vinnyhoward
Merge branch 'feat/mmassets-431_network-filter-ui' of github.com:Meta…
1297288 
…Mask/metamask-mobile into feat-431-network-filter-selector
@vinnyhoward
feat: partial update to token list related logic
7ddba48
@vinnyhoward
Merge branch 'feat-431-network-filter-selector' of github.com:MetaMas…
ae232b1 
…k/metamask-mobile into feat-431-network-filter-selector
@vinnyhoward
test: update comments
2a71002
Base automatically changed from feat/mmassets-431_network-filter-ui to main November 12, 2024 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
DO-NOT-MERGE Pull requests that should not be merged No E2E Smoke Needed If the PR does not need E2E smoke test run team-wallet-ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinnyhoward @gambinish @salimtb